[
https://issues.apache.org/jira/browse/YARN-11643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841253#comment-17841253
]
ASF GitHub Bot commented on YARN-11643:
---------------------------------------
hadoop-yetus commented on PR #6426:
URL: https://github.com/apache/hadoop/pull/6426#issuecomment-2079445379
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 01s | | No case conflicting files
found. |
| +0 :ok: | spotbugs | 0m 00s | | spotbugs executables are not
available. |
| +0 :ok: | codespell | 0m 00s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 00s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 01s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 00s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 108m 43s | | trunk passed |
| +1 :green_heart: | compile | 7m 28s | | trunk passed |
| +1 :green_heart: | checkstyle | 5m 38s | | trunk passed |
| +1 :green_heart: | mvnsite | 7m 06s | | trunk passed |
| +1 :green_heart: | javadoc | 6m 45s | | trunk passed |
| +1 :green_heart: | shadedclient | 179m 47s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 28s | | the patch passed |
| +1 :green_heart: | compile | 3m 52s | | the patch passed |
| +1 :green_heart: | javac | 3m 52s | | the patch passed |
| +1 :green_heart: | blanks | 0m 00s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 2m 43s | | the patch passed |
| +1 :green_heart: | mvnsite | 4m 04s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 38s | | the patch passed |
| +1 :green_heart: | shadedclient | 190m 47s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 6m 37s | | The patch does not
generate ASF License warnings. |
| | | 510m 34s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hadoop/pull/6426 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | MINGW64_NT-10.0-17763 80fcb844f29c 3.4.10-87d57229.x86_64
2024-02-14 20:17 UTC x86_64 Msys |
| Build tool | maven |
| Personality | /c/hadoop/dev-support/bin/hadoop.sh |
| git revision | trunk / 4c340e66690d361073ab7a746dbe4a9e7c446f2e |
| Default Java | Azul Systems, Inc.-1.8.0_332-b09 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6426/1/testReport/
|
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
|
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6426/1/console
|
| versions | git=2.44.0.windows.1 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Skip unnecessary pre-check in Multi Node Placement
> --------------------------------------------------
>
> Key: YARN-11643
> URL: https://issues.apache.org/jira/browse/YARN-11643
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacityscheduler
> Reporter: Xie YiFan
> Assignee: Xie YiFan
> Priority: Minor
> Labels: pull-request-available
>
> When Multi Node Placement enabled, RegularContainerAllocator do a while loop
> to find one node from candidate set to allocate for a given scheduler key.
> Before do allocate, pre-check be called to check if current node satisfies
> check. If this node does not pass all checks, just continue to next node.
> {code:java}
> if (reservedContainer == null) {
> result = preCheckForNodeCandidateSet(node,
> schedulingMode, resourceLimits, schedulerKey);
> if (null != result) {
> continue;
> }
> } {code}
> But some checks are related to scheduler Key or Application which return
> PRIORITY_SKIPPED or APP_SKIPPED. It means that if first node does not pass
> check, the following nodes also do not pass.
> If cluster have 5000 nodes in default partition, Scheduler will waste 5000
> times loop for just one scheduler key.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
