[
https://issues.apache.org/jira/browse/YARN-11711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871659#comment-17871659
]
ASF GitHub Bot commented on YARN-11711:
---------------------------------------
steveloughran commented on code in PR #6977:
URL: https://github.com/apache/hadoop/pull/6977#discussion_r1707069837
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/ServiceScheduler.java:
##########
@@ -1043,9 +1041,7 @@ private boolean terminateServiceIfAllComponentsFinished()
{
if (shouldTerminate) {
LOG.info("All component finished, exiting Service Master... "
- + ", final status=" + (failedComponents.isEmpty() ?
- "Succeeded" :
- "Failed"));
+ + ", final status={}", (failedComponents.isEmpty() ? "Succeeded" :
"Failed"));
Review Comment:
I'd prefer the ? : clause on its own line
> Improve ServiceScheduler Code
> -----------------------------
>
> Key: YARN-11711
> URL: https://issues.apache.org/jira/browse/YARN-11711
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler, yarn
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Minor
> Labels: pull-request-available
>
> HADOOP-16928 encountered a sputbug issue during compilation. The portion of
> code flagged by sputbug seems to be fine; we just need to bypass this
> validation. In addition, I made some minor improvements to other parts of the
> code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
