[
https://issues.apache.org/jira/browse/YARN-11782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931782#comment-17931782
]
ASF GitHub Bot commented on YARN-11782:
---------------------------------------
cnauroth commented on PR #7449:
URL: https://github.com/apache/hadoop/pull/7449#issuecomment-2692565629
> > +1 pending successful pre-submit.
> > The changes make sense to me, but I'm curious to know why the JUnit 5
upgrade revealed this problem. I'd expect if there was an assertion on these
test messages, then they would have failed in JUnit 4 too.
>
> @cnauroth Thank you very much for reviewing the code! I was able to
reproduce the issue by running the unit tests with Junit4 locally, but Yetus
did not detect it. For a long time, the YARN module used a mix of Junit4 and
Junit5, and this mixed approach may have caused the maven-surefire-plugin to
not filter out the problematic unit tests. However, once we fully upgraded to
Junit5, the exceptions in the unit tests were exposed.
That's very interesting! Do you think it indicates a Yetus bug? If so,
please file a bug against that project.
To be clear, I am still +1 on this patch, and thank you!
> [Federation] Fix incorrect error messages and improve failure handling.
> -----------------------------------------------------------------------
>
> Key: YARN-11782
> URL: https://issues.apache.org/jira/browse/YARN-11782
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: federation
> Affects Versions: 3.5.0, 3.4.2
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> While upgrading the JUnit tests for the yarn router module, I encountered
> some test failures. One of the errors was due to incorrect error messages. I
> will fix the incorrect error messages in this JIRA.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
