[
https://issues.apache.org/jira/browse/YARN-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859044#comment-13859044
]
Sandy Ryza commented on YARN-1029:
----------------------------------
Looked over the minicluster changes.
A couple tiny nits, otherwise LGTM:
* In MiniYarnCluster, failoverTimeout does not need to be initialized to 0
because it will always get set in serviceInit.
* In initResourceManager, index does not need to be final
* In initResourceManager, having the open paren on the line after register
looks a little weird, and new EventHandler<RMAppAttemptEvent>() should be at
the same indentation level as RMAppAttemptEventType.class.
* The thread in startResourceManager should be given a name (including the
index). Though if that's unrelated to this patch, leaving it how it is is fine.
* Why the added null check in getActiveRMIndex? When would one of the entries
in the resourceManagers array be null?
> Allow embedding leader election into the RM
> -------------------------------------------
>
> Key: YARN-1029
> URL: https://issues.apache.org/jira/browse/YARN-1029
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Karthik Kambatla
> Attachments: embedded-zkfc-approach.patch, yarn-1029-0.patch,
> yarn-1029-0.patch, yarn-1029-1.patch, yarn-1029-2.patch, yarn-1029-3.patch,
> yarn-1029-4.patch, yarn-1029-5.patch, yarn-1029-6.patch, yarn-1029-7.patch,
> yarn-1029-7.patch, yarn-1029-8.patch, yarn-1029-approach.patch
>
>
> It should be possible to embed common ActiveStandyElector into the RM such
> that ZooKeeper based leader election and notification is in-built. In
> conjunction with a ZK state store, this configuration will be a simple
> deployment option.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
