[
https://issues.apache.org/jira/browse/YARN-11698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18021700#comment-18021700
]
ASF GitHub Bot commented on YARN-11698:
---------------------------------------
Kimahriman commented on code in PR #6845:
URL: https://github.com/apache/hadoop/pull/6845#discussion_r2366448584
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java:
##########
@@ -783,15 +783,11 @@ public void removeVeryOldStoppedContainersFromCache() {
break;
}
if (!context.getContainers().containsKey(cid)) {
- ApplicationId appId =
- cid.getApplicationAttemptId().getApplicationId();
- if (isApplicationStopped(appId)) {
Review Comment:
Can you elaborate? Are you saying there is a problem with these changes? Or
something else wrong in the existing code?
> Finished containers shouldn't be stored indefinitely in the NM state store
> --------------------------------------------------------------------------
>
> Key: YARN-11698
> URL: https://issues.apache.org/jira/browse/YARN-11698
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 3.4.0
> Reporter: Adam Binford
> Priority: Major
> Labels: pull-request-available
>
> https://issues.apache.org/jira/browse/YARN-4771 updated the container
> tracking in the state store to only remove containers when their application
> ends, in order to make sure all containers logs get aggregated even during NM
> restarts. This can lead to a significant number of containers building up in
> the state store and a lot of things to recover. Since this was purely for
> making sure logs get aggregated, it could be done smarter that takes into
> account both rolling log aggregation or not having log aggregation enabled at
> all.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
