[ 
https://issues.apache.org/jira/browse/YARN-11874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18030476#comment-18030476
 ] 

ASF GitHub Bot commented on YARN-11874:
---------------------------------------

hadoop-yetus commented on PR #8033:
URL: https://github.com/apache/hadoop/pull/8033#issuecomment-3412890271

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 35s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  2s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  2s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  2s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  2s |  |  Shelldocs was not available.  |
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +0 :ok: |  jsonlint  |   0m  0s |  |  jsonlint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 95 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  10m 45s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  28m 24s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  15m 19s |  |  trunk passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  15m 39s |  |  trunk passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  checkstyle  |   2m 58s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m 51s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   3m 50s |  |  trunk passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   3m 34s |  |  trunk passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | +0 :ok: |  spotbugs  |   0m 48s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | -1 :x: |  spotbugs  |   2m 48s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8033/10/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html)
 |  hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1100 extant 
spotbugs warnings.  |
   | -1 :x: |  spotbugs  |   3m 17s | 
[/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8033/10/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 in trunk has 1298 extant spotbugs warnings.  |
   | +0 :ok: |  spotbugs  |   0m 43s |  |  
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file 
(spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  26m  7s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 38s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   8m 18s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  14m 43s |  |  the patch passed with JDK 
Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  14m 43s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m 41s |  |  the patch passed with JDK 
Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  15m 41s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   3m 14s | 
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8033/10/artifact/out/results-checkstyle-root.txt)
 |  root: The patch generated 70 new + 161 unchanged - 2 fixed = 231 total (was 
163)  |
   | +1 :green_heart: |  mvnsite  |   3m 50s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  |  No new issues.  |
   | -1 :x: |  javadoc  |   1m  9s | 
[/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8033/10/artifact/out/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt)
 |  
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04
 with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 generated 13 new + 5634 
unchanged - 0 fixed = 5647 total (was 5634)  |
   | -1 :x: |  javadoc  |   1m  9s | 
[/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8033/10/artifact/out/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt)
 |  
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04
 with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 generated 12 new + 5436 
unchanged - 0 fixed = 5448 total (was 5436)  |
   | +0 :ok: |  spotbugs  |   0m 41s |  |  hadoop-project has no data from 
spotbugs  |
   | -1 :x: |  spotbugs  |   3m 33s | 
[/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8033/10/artifact/out/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html)
 |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 generated 13 new + 1292 unchanged - 6 fixed = 1305 total (was 1298)  |
   | +0 :ok: |  spotbugs  |   0m 43s |  |  
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs  |
   | +1 :green_heart: |  shadedclient  |  27m  9s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 41s |  |  hadoop-project in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   5m 40s |  |  hadoop-yarn-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 105m 31s |  |  
hadoop-yarn-server-resourcemanager in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 42s |  |  hadoop-client-minicluster in 
the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  2s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 330m 47s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | SpotBugs | 
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 |
   |  |  new 
org.apache.hadoop.yarn.server.resourcemanager.federation.FederationStateStoreHeartbeat(SubClusterId,
 FederationStateStore, ResourceScheduler, JAXBContextResolver) may expose 
internal representation by storing an externally mutable object into 
FederationStateStoreHeartbeat.rs  At FederationStateStoreHeartbeat.java:may 
expose internal representation by storing an externally mutable object into 
FederationStateStoreHeartbeat.rs  At FederationStateStoreHeartbeat.java:[line 
65] |
   |  |  new 
org.apache.hadoop.yarn.server.resourcemanager.federation.FederationStateStoreHeartbeat(SubClusterId,
 FederationStateStore, ResourceScheduler, JAXBContextResolver) may expose 
internal representation by storing an externally mutable object into 
FederationStateStoreHeartbeat.stateStoreService  At 
FederationStateStoreHeartbeat.java:may expose internal representation by 
storing an externally mutable object into 
FederationStateStoreHeartbeat.stateStoreService  At 
FederationStateStoreHeartbeat.java:[line 63] |
   |  |  new 
org.apache.hadoop.yarn.server.resourcemanager.federation.FederationStateStoreHeartbeat(SubClusterId,
 FederationStateStore, ResourceScheduler, JAXBContextResolver) may expose 
internal representation by storing an externally mutable object into 
FederationStateStoreHeartbeat.subClusterId  At 
FederationStateStoreHeartbeat.java:may expose internal representation by 
storing an externally mutable object into 
FederationStateStoreHeartbeat.subClusterId  At 
FederationStateStoreHeartbeat.java:[line 64] |
   |  |  Unknown bug pattern CT_CONSTRUCTOR_THROW in new 
org.apache.hadoop.yarn.server.resourcemanager.webapp.JAXBContextResolver()  At 
JAXBContextResolver.java:new 
org.apache.hadoop.yarn.server.resourcemanager.webapp.JAXBContextResolver()  At 
JAXBContextResolver.java:[line 47] |
   |  |  Unknown bug pattern CT_CONSTRUCTOR_THROW in new 
org.apache.hadoop.yarn.server.resourcemanager.webapp.JAXBContextResolver(Configuration)
  At JAXBContextResolver.java:new 
org.apache.hadoop.yarn.server.resourcemanager.webapp.JAXBContextResolver(Configuration)
  At JAXBContextResolver.java:[line 58] |
   |  |  
org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.NodeLabelsInfo.getNodeLabelsInfo()
 may expose internal representation by returning NodeLabelsInfo.nodeLabelInfo  
At NodeLabelsInfo.java:by returning NodeLabelsInfo.nodeLabelInfo  At 
NodeLabelsInfo.java:[line 67] |
   |  |  new 
org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.NodeLabelsInfo(ArrayList)
 may expose internal representation by storing an externally mutable object 
into NodeLabelsInfo.nodeLabelInfo  At NodeLabelsInfo.java:representation by 
storing an externally mutable object into NodeLabelsInfo.nodeLabelInfo  At 
NodeLabelsInfo.java:[line 42] |
   |  |  
org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.NodeLabelsInfo.setNodeLabelInfo(ArrayList)
 may expose internal representation by storing an externally mutable object 
into NodeLabelsInfo.nodeLabelInfo  At NodeLabelsInfo.java:by storing an 
externally mutable object into NodeLabelsInfo.nodeLabelInfo  At 
NodeLabelsInfo.java:[line 92] |
   |  |  
org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.NodeLabelsInfo.setNodeLabelsInfo(ArrayList)
 may expose internal representation by storing an externally mutable object 
into NodeLabelsInfo.nodeLabelInfo  At NodeLabelsInfo.java:by storing an 
externally mutable object into NodeLabelsInfo.nodeLabelInfo  At 
NodeLabelsInfo.java:[line 88] |
   |  |  Unknown bug pattern CT_CONSTRUCTOR_THROW in new 
org.apache.hadoop.yarn.server.resourcemanager.webapp.jsonprovider.ClassSerialisationConfig()
  At ClassSerialisationConfig.java:new 
org.apache.hadoop.yarn.server.resourcemanager.webapp.jsonprovider.ClassSerialisationConfig()
  At ClassSerialisationConfig.java:[line 208] |
   |  |  Unknown bug pattern CT_CONSTRUCTOR_THROW in new 
org.apache.hadoop.yarn.server.resourcemanager.webapp.jsonprovider.ClassSerialisationConfig(Configuration)
  At ClassSerialisationConfig.java:new 
org.apache.hadoop.yarn.server.resourcemanager.webapp.jsonprovider.ClassSerialisationConfig(Configuration)
  At ClassSerialisationConfig.java:[line 234] |
   |  |  
org.apache.hadoop.yarn.server.resourcemanager.webapp.jsonprovider.ClassSerialisationConfig.getUnWrappedClasses()
 may expose internal representation by returning 
ClassSerialisationConfig.unWrappedClasses  At ClassSerialisationConfig.java:by 
returning ClassSerialisationConfig.unWrappedClasses  At 
ClassSerialisationConfig.java:[line 243] |
   |  |  
org.apache.hadoop.yarn.server.resourcemanager.webapp.jsonprovider.ClassSerialisationConfig.getWrappedClasses()
 may expose internal representation by returning 
ClassSerialisationConfig.wrappedClasses  At ClassSerialisationConfig.java:by 
returning ClassSerialisationConfig.wrappedClasses  At 
ClassSerialisationConfig.java:[line 239] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.51 ServerAPI=1.51 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8033/10/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8033 |
   | Optional Tests | dupname asflicense codespell detsecrets shellcheck 
shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xmllint 
spotbugs checkstyle jsonlint |
   | uname | Linux e8f9ad906217 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 
00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / ba4ab13eb2a710900933646670a184f122b14d06 |
   | Default Java | Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8033/10/testReport/ |
   | Max. process+thread count | 940 (vs. ulimit of 5500) |
   | modules | C: hadoop-project 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 hadoop-client-modules/hadoop-client-minicluster U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8033/10/console |
   | versions | git=2.25.1 maven=3.9.11 spotbugs=4.9.7 shellcheck=0.7.0 |
   | Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> ResourceManager REST api scheduler info contains @xsi.type instead of type
> --------------------------------------------------------------------------
>
>                 Key: YARN-11874
>                 URL: https://issues.apache.org/jira/browse/YARN-11874
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 3.5.0
>            Reporter: Bence Kosztolnik
>            Assignee: Bence Kosztolnik
>            Priority: Major
>              Labels: pull-request-available
>
> *Problem statement:*
> The /ws/v1/cluster/scheduler returns with invalid response
> {code:java}
> {
>     "scheduler": {
>         "schedulerInfo": {
>                  "@xsi.type":"fifoScheduler",
>                  "capacity":1,
>                  ...
> {code}
> instead of this:
> {code:java}
> {
>     "scheduler": {
>         "schedulerInfo": {
>                  "type":"fifoScheduler",
>                  "capacity":1,
>                  ...
> {code}
> source: 
> https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-site/ResourceManagerRest.html#Cluster_Scheduler_API
> *Repro:*
> 1) Modify the TestRMWebServices#verifyClusterSchedulerFifo and add the line
> {code:java}
>     assertTrue(info.has("type"),  "incorrect type of element: " + info);
> {code}
> 2) Run the testClusterSchedulerFifo test, it will fail
> *Possible root cause:*
> I think during the jersey2 upgrade when 
> *org.apache.hadoop.yarn.server.resourcemanager.webapp.JAXBContextResolver* 
> was modified with replacement of *com.sun.jersey.api.json.JSONJAXBContext* to 
> *org.glassfish.jersey.jettison.JettisonJaxbContext* we changed the 
> behaviourment how we convert the XML models to JSON in the REST API.
> https://github.com/apache/hadoop/blob/06d36f5a6a1a01d159bef75b22ca2845e8c90bad/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/JAXBContextResolver.java#L158
> *Other failures:*
> When we generate a UI list with only one element it will be converted to json 
> object instead of list with single element.
> For example the doc says
> {noformat}
> queues        array of queues(JSON)/zero or more queue objects(XML)
> {noformat}
> in context of schedulerInfo object, but if we have just one queue it wont be 
> an array, just a simple queue object.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to