[
https://issues.apache.org/jira/browse/YARN-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18032099#comment-18032099
]
ASF GitHub Bot commented on YARN-11881:
---------------------------------------
steveloughran commented on code in PR #8046:
URL: https://github.com/apache/hadoop/pull/8046#discussion_r2452090733
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-server/hadoop-yarn-server-timelineservice-hbase-server-2/pom.xml:
##########
@@ -88,6 +92,7 @@
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-common</artifactId>
+ <scope>provided</scope>
Review Comment:
do we need this at all, given the shaded one is there? Is it testing related?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-server/hadoop-yarn-server-timelineservice-hbase-server-2/pom.xml:
##########
@@ -107,6 +112,7 @@
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-client</artifactId>
Review Comment:
same comment -seems superflous.
> Use hbase-shaded-client-byo-hadoop in hadoop-yarn-server-timelineservice-hbase
> ------------------------------------------------------------------------------
>
> Key: YARN-11881
> URL: https://issues.apache.org/jira/browse/YARN-11881
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineservice
> Affects Versions: 3.4.2
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Labels: pull-request-available
>
> The HBase timelineservice backed is currently using the unshaded HBase client.
> This brings in a lot of HBase dependencies, most critically protobuf 2.5.
> Use hbase-shaded-client-byo-hadoop which shades protobuf-java 2.5 so that it
> won't conflict with other Protobuf versions on the classpath, and removes
> several other dependencies from the Yarn classpath.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
