[ 
https://issues.apache.org/jira/browse/YARN-11909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18046135#comment-18046135
 ] 

ASF GitHub Bot commented on YARN-11909:
---------------------------------------

p-szucs commented on code in PR #8136:
URL: https://github.com/apache/hadoop/pull/8136#discussion_r2630087344


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/util/WebServiceClient.java:
##########
@@ -67,8 +67,7 @@ public static WebServiceClient getWebServiceClient() {
     return instance;
   }
 
-  @VisibleForTesting
-  SSLFactory getSSLFactory() {
+  public static SSLFactory getSSLFactory() {

Review Comment:
   Thanks for the review @slfan1989!
   As I could see we can not reach the SSL factory from the Logs CLI without 
this





> Fetching logs for a running application fails on a secure environment
> ---------------------------------------------------------------------
>
>                 Key: YARN-11909
>                 URL: https://issues.apache.org/jira/browse/YARN-11909
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 3.5.0
>            Reporter: Peter Szucs
>            Assignee: Peter Szucs
>            Priority: Major
>              Labels: pull-request-available
>
> URL connectivity check in YARN Logs CLI can not connect to the RM on a 
> secured environment when getting the logs for a running application.
> Jersey 2 upgrade introduced a new logic for checking URL connectivity before 
> getting the logs from the appropriate services.
> This logic uses {{HttpURLConnection}} that can not load SSL configuration 
> from the ssl-client.xml on a secure environment. As I can see in such cases 
> we need to use {{HttpsURLConnection}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to