[
https://issues.apache.org/jira/browse/YARN-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18046862#comment-18046862
]
ASF GitHub Bot commented on YARN-9680:
--------------------------------------
github-actions[bot] commented on PR #1178:
URL: https://github.com/apache/hadoop/pull/1178#issuecomment-3678240511
We're closing this stale PR because it has been open for 100 days with no
activity. This isn't a judgement on the merit of the PR in any way. It's just a
way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working
on it, please feel free to re-open it and ask for a committer to remove the
stale tag and review again.
Thanks all for your contribution.
> Code cleanup in ResourcePluginManager init methods
> --------------------------------------------------
>
> Key: YARN-9680
> URL: https://issues.apache.org/jira/browse/YARN-9680
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Priority: Major
>
> We have 2 initializer methods in this class:
> 1.
> org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.ResourcePluginManager#initialize
> 2.
> org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.ResourcePluginManager#initializePluggableDevicePlugins
> Both are overly complex, contains nested conditions / loops.
> A simple refactor could be performed (along with tests) on these methods, for
> example, by splitting them into smaller methods, as a start.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
