[ 
https://issues.apache.org/jira/browse/YARN-11916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18049900#comment-18049900
 ] 

ASF GitHub Bot commented on YARN-11916:
---------------------------------------

steveloughran opened a new pull request, #8164:
URL: https://github.com/apache/hadoop/pull/8164

   * Move the class. It was never public API.
   * Added the test artifact at test scope to yarn-client for its tests.
   * Javadocs make really, really clear this isn't for production.
   * General resilience hardening and tests while there. 
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> FileSystemTimelineReaderImpl vulnerable to race conditions
> ----------------------------------------------------------
>
>                 Key: YARN-11916
>                 URL: https://issues.apache.org/jira/browse/YARN-11916
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: timelineserver
>    Affects Versions: 3.4.2
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>
> Yarn timelineserver FileSystemTimelineReaderImpl implementation does atomic 
> updates via: copy, append, rename. This gives it bad scalability and 
> concurrent calls will lose data.
>  has bad concurrency on write and will lose updates. And its scalability 
> Not plans to fix what was just the PoC of the v2 API, just
> * update javadocs
> * warn on startup that people should stop it.
> * do some other hardening while there, and test cleanup
> This code is @Private/@Unstable. Maybe we can move it into the -test jar. 
> Nobody will complain.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to