[ https://issues.apache.org/jira/browse/YARN-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863644#comment-13863644 ]
Jian He commented on YARN-1506: ------------------------------- Wasn’t following YARN-291 too much. Some things I noticed. - What about other node states other than RUNNING, is RESOURCE_UPDATE event never possible to come at those states? - ResourceOption.build() is not used anywhere? - Maybe send the NODE_RESOURCE_UPDATE event from RMNode instead from AdminService? as inside SchedulerEventType, it’s actually saying the source is from node. > Replace set resource change on RMNode/SchedulerNode directly with event > notification. > ------------------------------------------------------------------------------------- > > Key: YARN-1506 > URL: https://issues.apache.org/jira/browse/YARN-1506 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, scheduler > Reporter: Junping Du > Assignee: Junping Du > Priority: Blocker > Attachments: YARN-1506-v1.patch, YARN-1506-v2.patch, > YARN-1506-v3.patch, YARN-1506-v4.patch > > > According to Vinod's comments on YARN-312 > (https://issues.apache.org/jira/browse/YARN-312?focusedCommentId=13846087&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13846087), > we should replace RMNode.setResourceOption() with some resource change event. -- This message was sent by Atlassian JIRA (v6.1.5#6160)