[ https://issues.apache.org/jira/browse/YARN-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881499#comment-13881499 ]
Chen He commented on YARN-1479: ------------------------------- Hi [~jeagles] Thank you for your suggestion. I can answer your questions one by one. {quote}There are a couple of unnecessary imports in TestApplicationMasterService. Let's get those cleaned up before this patch goes in.{quote} I have removed those unnecessary imports; {quote}progressCheck - the function will be better off package-private since the intention is not to advertise new functionality{quote} {quote}progressCheck - this function should be renamed since check is a question and not an indication something is being modified. Perhaps progressFilter or hopefully you can think of something better.{quote} If progressCheck is package-private, it can not be directly called in the TestApplicationMasterSerive since Yarn-1632; I will remove progressCheck method in the yarn-1479v2.patch and migrate its code into ApplicationMasterService.allocate() method. Then, we only need to have testAllocate() method in TestApplicationMasterService. > Invalid NaN values in Hadoop REST API JSON response > --------------------------------------------------- > > Key: YARN-1479 > URL: https://issues.apache.org/jira/browse/YARN-1479 > Project: Hadoop YARN > Issue Type: Improvement > Affects Versions: 0.23.6, 2.0.4-alpha > Reporter: Kendall Thrapp > Assignee: Chen He > Fix For: 2.4.0 > > Attachments: Yarn-1479.patch > > > I've been occasionally coming across instances where Hadoop's Cluster > Applications REST API > (http://hadoop.apache.org/docs/r0.23.6/hadoop-yarn/hadoop-yarn-site/ResourceManagerRest.html#Cluster_Applications_API) > has returned JSON that PHP's json_decode function failed to parse. I've > tracked the syntax error down to the presence of the unquoted word NaN > appearing as a value in the JSON. For example: > "progress":NaN, > NaN is not part of the JSON spec, so its presence renders the whole JSON > string invalid. Hadoop needs to return something other than NaN in this case > -- perhaps an empty string or the quoted string "NaN". -- This message was sent by Atlassian JIRA (v6.1.5#6160)