[ 
https://issues.apache.org/jira/browse/YARN-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891795#comment-13891795
 ] 

Vinod Kumar Vavilapalli commented on YARN-1461:
-----------------------------------------------

Tx Karthik. Looks fine overall.

I don't like the names startRange, finishRange. But that isn't caused by your 
patch. We can change them separately.

Also, for some reason, the setters are all marked private unnecessarily. Again 
unrelated, will file a ticket.

> RM API and RM changes to handle tags for running jobs
> -----------------------------------------------------
>
>                 Key: YARN-1461
>                 URL: https://issues.apache.org/jira/browse/YARN-1461
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.2.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: yarn-1461-1.patch, yarn-1461-10.patch, 
> yarn-1461-11.patch, yarn-1461-12.patch, yarn-1461-13.patch, 
> yarn-1461-2.patch, yarn-1461-3.patch, yarn-1461-4.patch, yarn-1461-5.patch, 
> yarn-1461-6.patch, yarn-1461-6.patch, yarn-1461-7.patch, yarn-1461-8.patch, 
> yarn-1461-9.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to