[ https://issues.apache.org/jira/browse/YARN-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898575#comment-13898575 ]
Hadoop QA commented on YARN-1717: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12628373/YARN-1717.1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3074//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/3074//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-applicationhistoryservice.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3074//console This message is automatically generated. > Misc improvements to leveldb timeline store > ------------------------------------------- > > Key: YARN-1717 > URL: https://issues.apache.org/jira/browse/YARN-1717 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Billie Rinaldi > Assignee: Billie Rinaldi > Attachments: YARN-1717.1.patch > > > The leveldb timeline store implementation needs the following: > * better documentation of its internal structures > * braces for all control flow statements > * simple locking to prevent issues related to concurrent writes > * internal changes to enable deleting entities > ** never overwrite existing primary filter entries > ** add hidden reverse pointers to related entities -- This message was sent by Atlassian JIRA (v6.1.5#6160)