[ 
https://issues.apache.org/jira/browse/YARN-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909771#comment-13909771
 ] 

Hudson commented on YARN-1732:
------------------------------

SUCCESS: Integrated in Hadoop-Hdfs-trunk #1682 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1682/])
YARN-1732. Changed types of related-entities and primary-filters in the 
timeline-service to be sets instead of maps. Contributed by Billie Rinaldi. 
(vinodkv: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1570914)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/apptimeline/ATSEntity.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/apptimeline/GenericObjectMapper.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/apptimeline/LeveldbApplicationTimelineStore.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/apptimeline/MemoryApplicationTimelineStore.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/apptimeline/ApplicationTimelineStoreTestUtils.java


> Change types of related entities and primary filters in ATSEntity
> -----------------------------------------------------------------
>
>                 Key: YARN-1732
>                 URL: https://issues.apache.org/jira/browse/YARN-1732
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>             Fix For: 2.4.0
>
>         Attachments: YARN-1732.1.patch, YARN-1732.2.patch, YARN-1732.3.patch
>
>
> The current types Map<String, List<String>> relatedEntities and Map<String, 
> Object> primaryFilters have issues.  The List<String> value of the related 
> entities map could have multiple identical strings in it, which doesn't make 
> sense. A more major issue is that we cannot allow primary filter values to be 
> overwritten, because otherwise we will be unable to find those primary filter 
> entries when we want to delete an entity (without doing a nearly full scan).
> I propose changing related entities to Map<String, Set<String>> and primary 
> filters to Map<String, Set<Object>>.  The basic methods to add primary 
> filters and related entities are of the form add(key, value) and will not 
> need to change.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to