[ 
https://issues.apache.org/jira/browse/YARN-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925427#comment-13925427
 ] 

Xuan Gong commented on YARN-1764:
---------------------------------

bq. Can you add a log in YarnClientImpl when we retry the submission?

DONE

bq. Can you improvement the documentation of submitApp() API in 
ApplicationClientProtocol about the clients needing to retry when the specified 
exception happens?

ADDED

bq. Also add the exception to the documentation to the base protocol.

ADDED

bq. Document YarnClient's submit API that we automatically retry when this 
issue happens.

ADDED

bq. All the new files added in the patch have some formatting issues.

FIXED

bq. In both the test-cases, after the fail-over, we assert for the states that 
are not expected (assertFalse). Can we explicitly test for the cases that we 
expect (assertTrue) ?

changed

bq. I think we should also mark getApplicationReport() to be idempotent in this 
patch itself as RM can fail-over after submitApplication() returned but during 
a getApplicationReport(). We will need to add some tests for this too.

ADDED

> Handle RM fail overs after the submitApplication call.
> ------------------------------------------------------
>
>                 Key: YARN-1764
>                 URL: https://issues.apache.org/jira/browse/YARN-1764
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-1764.1.patch, YARN-1764.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to