[ 
https://issues.apache.org/jira/browse/YARN-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935673#comment-13935673
 ] 

Hadoop QA commented on YARN-1833:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12634829/YARN-1833-v2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart

                                      The following test timeouts occurred in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3370//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3370//console

This message is automatically generated.

> TestRMAdminService Fails in trunk and branch-2
> ----------------------------------------------
>
>                 Key: YARN-1833
>                 URL: https://issues.apache.org/jira/browse/YARN-1833
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>              Labels: Test
>         Attachments: YARN-1833-v2.patch, YARN-1833.patch
>
>
> In the test 
> testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider, the 
> following assert is not needed.
> {code}
> Assert.assertTrue(groupWithInit.size() != groupBefore.size());
> {code}
> As the assert takes the default groups for groupWithInit (which in my case 
> are users, sshusers and wheel), it fails as the size of both groupWithInit 
> and groupBefore are same.
> I do not think we need to have this assert here. Moreover we are also 
> checking that the groupInit does not have the userGroups that are in the 
> groupBefore so removing the assert may not be harmful.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to