[ 
https://issues.apache.org/jira/browse/YARN-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940879#comment-13940879
 ] 

Mayank Bansal commented on YARN-1809:
-------------------------------------

Thanks [~zjshen] for the patch.
Herer are some comments

1. Change name from ApplicationInformationProtocol to like 
ApplicationBaseProtocol
2. Why we cant have delegationtoken related api's to Base Protocol?
3. ApplicationHistoryClientService -> Why we removing protocol handler? I think 
we should keep it as it was.
4. I am not sure why we removed the ApplicationContext, I think 
ApplicationContext shoule be retained
    Isn't it that good if we have the following structure
bq . ApplicationBaseProtocol derived by ApplicationContext
Thoughts?
5. There are lot of refactoring in the patch , which is good but we could have 
seprated in two JIRAs which will make changes central to specific issue. 
Thoughts?





> Synchronize RM and Generic History Service Web-UIs
> --------------------------------------------------
>
>                 Key: YARN-1809
>                 URL: https://issues.apache.org/jira/browse/YARN-1809
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-1809.1.patch, YARN-1809.2.patch, YARN-1809.3.patch, 
> YARN-1809.4.patch, YARN-1809.5.patch, YARN-1809.5.patch
>
>
> After YARN-953, the web-UI of generic history service is provide more 
> information than that of RM, the details about app attempt and container. 
> It's good to provide similar web-UIs, but retrieve the data from separate 
> source, i.e., RM cache and history store respectively.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to