[
https://issues.apache.org/jira/browse/YARN-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941094#comment-13941094
]
Vinod Kumar Vavilapalli commented on YARN-1775:
-----------------------------------------------
Some comments:
- This new class is just an extension of ProcfsBasedProcessTree, so is better
served by using the same util class (from the admin's point of view) but with
an additional configuration option to better track RSS
- Can you explain why we are doing this
{code}
+ total += Math.min(info.sharedDirty, info.pss) + info.privateDirty
+ + info.privateClean;
{code}
Test
- Most of the test-code is duplicating testProcfsBasedProcess. Can you avoid
that?
- Reuse at least some of MemoryMappingInfo, ProcessMemInfo etc from the
regular code instead of duplicating in the test?
Lost of white spaces in the patch, mostly empty lines.
> Create SMAPBasedProcessTree to get PSS information
> --------------------------------------------------
>
> Key: YARN-1775
> URL: https://issues.apache.org/jira/browse/YARN-1775
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Rajesh Balamohan
> Assignee: Rajesh Balamohan
> Attachments: yarn-1775-2.4.0.patch
>
>
> Create SMAPBasedProcessTree (by extending ProcfsBasedProcessTree), which will
> make use of PSS for computing the memory usage.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
