[ https://issues.apache.org/jira/browse/YARN-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943542#comment-13943542 ]
Hadoop QA commented on YARN-1536: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636094/yarn-1536.003.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 15 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3426//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3426//console This message is automatically generated. > Cleanup: Get rid of ResourceManager#get*SecretManager() methods and use the > RMContext methods instead > ----------------------------------------------------------------------------------------------------- > > Key: YARN-1536 > URL: https://issues.apache.org/jira/browse/YARN-1536 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager > Affects Versions: 2.3.0 > Reporter: Karthik Kambatla > Assignee: Anubhav Dhoot > Priority: Minor > Labels: newbie > Attachments: yarn-1536.002.patch, yarn-1536.003.patch, yarn-1536.patch > > > Both ResourceManager and RMContext have methods to access the secret > managers, and it should be safe (cleaner) to get rid of the ResourceManager > methods. -- This message was sent by Atlassian JIRA (v6.2#6252)