[
https://issues.apache.org/jira/browse/YARN-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943745#comment-13943745
]
Zhijie Shen commented on YARN-1838:
-----------------------------------
Billie, thanks for the new patch. It looks good to me. Based on your patch, I
just made some minor touch: remove unnecessary suppresswarning, format a piece
of javadoc, and enhance the test of testGetEntitiesWithFromTs
Vinod, do you want to have a look as well?
> Timeline service getEntities API should provide ability to get entities from
> given id
> -------------------------------------------------------------------------------------
>
> Key: YARN-1838
> URL: https://issues.apache.org/jira/browse/YARN-1838
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Srimanth Gunturi
> Assignee: Billie Rinaldi
> Attachments: YARN-1838.1.patch, YARN-1838.2.patch, YARN-1838.3.patch,
> YARN-1838.4.patch, YARN-1838.5.patch
>
>
> To support pagination, we need ability to get entities from a certain ID by
> providing a new param called {{fromid}}.
> For example on a page of 10 jobs, our first call will be like
> [http://server:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&limit=11]
> When user hits next, we would like to call
> [http://server:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&fromid=JID11&limit=11]
> and continue on for further _Next_ clicks
> On hitting back, we will make similar calls for previous items
> [http://server:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&fromid=JID1&limit=11]
> {{fromid}} should be inclusive of the id given.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
