[ 
https://issues.apache.org/jira/browse/YARN-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947399#comment-13947399
 ] 

Karthik Kambatla commented on YARN-1521:
----------------------------------------

Looked at the non-test source only. Looks good. One nit - it should be okay to 
fix at commit time. 
# Reword to "it checks whether the application already exists"?
{code}
   * <p>During the submission process, it checks whether the application
   * has already exist. If the application exists, it will simply return
   * SubmitApplicationResponse</p>
{code}


> Mark appropriate protocol methods with the idempotent annotation or 
> AtMostOnce annotation
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-1521
>                 URL: https://issues.apache.org/jira/browse/YARN-1521
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-1521.0.patch, YARN-1521.1.patch, YARN-1521.2.patch
>
>
> After YARN-1028, we add the automatically failover into RMProxy. This JIRA is 
> to identify whether we need to add idempotent annotation and which methods 
> can be marked as idempotent.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to