[ https://issues.apache.org/jira/browse/YARN-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948800#comment-13948800 ]
Akira AJISAKA commented on YARN-1883: ------------------------------------- Good catch and thanks for the patch. {code} + // reset the groups to what it were before updating + MockUnixGroupsMapping.resetGroups(); {code} I think it would be better to move {{resetGroups()}} into {{setup()}} method to avoid developers forgetting to call {{resetGroup()}} in each required method. That way we can remove the initialization {code} @SuppressWarnings("serial") private static List<String> group = new ArrayList<String>() {{ add("test_group_A"); add("test_group_B"); add("test_group_C"); }}; {code} > TetsRMAdminService fails due to inconsistent entries in UserGroups > ------------------------------------------------------------------ > > Key: YARN-1883 > URL: https://issues.apache.org/jira/browse/YARN-1883 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 3.0.0, 2.4.0 > Reporter: Mit Desai > Assignee: Mit Desai > Labels: java7 > Attachments: YARN-1883.patch > > > testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider fails > with the following error: > {noformat} > java.lang.AssertionError: null > at org.junit.Assert.fail(Assert.java:92) > at org.junit.Assert.assertTrue(Assert.java:43) > at org.junit.Assert.assertTrue(Assert.java:54) > at > org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider(TestRMAdminService.java:421) > at > org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testOrder(TestRMAdminService.java:104) > {noformat} > Line Numbers will be inconsistent as I was testing to run it in a particular > order. But the Line on which the failure occurs is > {code} > Assert.assertTrue(groupBefore.contains("test_group_A") > && groupBefore.contains("test_group_B") > && groupBefore.contains("test_group_C") && groupBefore.size() == 3); > {code} > testRMInitialsWithFileSystemBasedConfigurationProvider() and > testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider() > calls the function {{MockUnixGroupsMapping.updateGroups();}} which changes > the list of userGroups. > testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider() > tries to verify the groups before changing it and fails if > testRMInitialsWithFileSystemBasedConfigurationProvider() already ran and made > the changes. -- This message was sent by Atlassian JIRA (v6.2#6252)