[ https://issues.apache.org/jira/browse/YARN-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950391#comment-13950391 ]
Hadoop QA commented on YARN-1887: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637331/YARN-1887.1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3480//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3480//console This message is automatically generated. > FairSchedulerAppsBlock and AppsBlock duplicate much code > -------------------------------------------------------- > > Key: YARN-1887 > URL: https://issues.apache.org/jira/browse/YARN-1887 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Zhijie Shen > Assignee: Tsuyoshi OZAWA > Attachments: YARN-1887.1.patch > > > Either now or after YARN-1809, FairSchedulerAppsBlock and AppsBlock duplicate > much code. Ideally, FairSchedulerAppsBlock should extends AppsBlock to reuse > most code, and override the method of creating app table headers and rows -- This message was sent by Atlassian JIRA (v6.2#6252)