[
https://issues.apache.org/jira/browse/YARN-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960809#comment-13960809
]
Xuan Gong commented on YARN-1903:
---------------------------------
+1 LGTM
Also, I run the TestNMClient with this patch applied on Windows several times.
All of them are passed.
> Killing Container on NEW and LOCALIZING will result in exitCode and
> diagnostics not set
> ---------------------------------------------------------------------------------------
>
> Key: YARN-1903
> URL: https://issues.apache.org/jira/browse/YARN-1903
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Attachments: YARN-1903.1.patch
>
>
> The container status after stopping container is not expected.
> {code}
> java.lang.AssertionError: 4:
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at
> org.apache.hadoop.yarn.client.api.impl.TestNMClient.testGetContainerStatus(TestNMClient.java:382)
> at
> org.apache.hadoop.yarn.client.api.impl.TestNMClient.testContainerManagement(TestNMClient.java:346)
> at
> org.apache.hadoop.yarn.client.api.impl.TestNMClient.testNMClient(TestNMClient.java:226)
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
