[ https://issues.apache.org/jira/browse/YARN-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962405#comment-13962405 ]
Ivan Mitic commented on YARN-1865: ---------------------------------- Thanks Remus for the new patch. I have one more comment, can you please also include a unit test that validates errorCheck() behavior on Unix? You can either try to come up with a shell cmd line that will fail on both Unix and Windows, or add a separate unittest for Unix. > ShellScriptBuilder does not check for some error conditions > ----------------------------------------------------------- > > Key: YARN-1865 > URL: https://issues.apache.org/jira/browse/YARN-1865 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 3.0.0, 2.2.0, 2.3.0 > Reporter: Remus Rusanu > Assignee: Remus Rusanu > Priority: Minor > Attachments: YARN-1865.1.patch, YARN-1865.2.patch, YARN-1865.3.patch > > > The WindowsShellScriptBuilder does not check for commands exceeding windows > maximum shell command line length (8191 chars) > Neither Unix nor Windows script builder do not check for error condition > after mkdir nor link > WindowsShellScriptBuilder mkdir is not safe with regard to paths containing > spaces -- This message was sent by Atlassian JIRA (v6.2#6252)