[ https://issues.apache.org/jira/browse/YARN-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963480#comment-13963480 ]
Zhijie Shen commented on YARN-1907: ----------------------------------- The patch makes sense to me. I tried the test in eclipse as well. Sometimes it would be failed after 200 rounds of node heartbeat, and the container still haven't completed cleaned up. However, is it a better code practice to loop until all the containers are cleaned up (removing the 200 round bounds), and set a suitable timeout for this test case? > TestRMApplicationHistoryWriter#testRMWritingMassiveHistory runs slow and > intermittently fails > --------------------------------------------------------------------------------------------- > > Key: YARN-1907 > URL: https://issues.apache.org/jira/browse/YARN-1907 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 3.0.0, 2.5.0 > Reporter: Mit Desai > Assignee: Mit Desai > Attachments: HDFS-6195.patch > > > The test has 10000 containers that it tries to cleanup. > The cleanup has a timeout of 20000ms in which the test sometimes cannot do > the cleanup completely and gives out an Assertion Failure. -- This message was sent by Atlassian JIRA (v6.2#6252)