[ https://issues.apache.org/jira/browse/YARN-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975687#comment-13975687 ]
Hadoop QA commented on YARN-1954: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12641071/YARN-1954.3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3601//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3601//console This message is automatically generated. > Add waitFor to AMRMClient(Async) > -------------------------------- > > Key: YARN-1954 > URL: https://issues.apache.org/jira/browse/YARN-1954 > Project: Hadoop YARN > Issue Type: New Feature > Components: client > Affects Versions: 3.0.0, 2.4.0 > Reporter: Zhijie Shen > Assignee: Tsuyoshi OZAWA > Attachments: YARN-1954.1.patch, YARN-1954.2.patch, YARN-1954.3.patch > > > Recently, I saw some use cases of AMRMClient(Async). The painful thing is > that the main non-daemon thread has to sit in a dummy loop to prevent AM > process exiting before all the tasks are done, while unregistration is > triggered on a separate another daemon thread by callback methods (in > particular when using AMRMClientAsync). IMHO, it should be beneficial to add > a waitFor method to AMRMClient(Async) to block the AM until unregistration or > user supplied check point, such that users don't need to write the loop > themselves. -- This message was sent by Atlassian JIRA (v6.2#6252)