[ https://issues.apache.org/jira/browse/YARN-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997192#comment-13997192 ]
Wangda Tan commented on YARN-2017: ---------------------------------- bq. On a second thought, user might pass in a resource request with null capability. I would prefer not changing it. In fact, we can add many other null checks in many places. Changed the patch back. I think null capability should be checked by ApplicationMasterService and throw exception before passed in. So do or don't do null pointer checking should be fine :) > Merge some of the common lib code in schedulers > ----------------------------------------------- > > Key: YARN-2017 > URL: https://issues.apache.org/jira/browse/YARN-2017 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Jian He > Assignee: Jian He > Attachments: YARN-2017.1.patch, YARN-2017.2.patch, YARN-2017.3.patch > > > A bunch of same code is repeated among schedulers, e.g: between > FicaSchedulerNode and FSSchedulerNode. It's good to merge and share them in a > common base. -- This message was sent by Atlassian JIRA (v6.2#6252)