[ https://issues.apache.org/jira/browse/YARN-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14007786#comment-14007786 ]
Sandy Ryza commented on YARN-2083: ---------------------------------- I think it would be better to solve this by making sure the queue cannot actually exceed the maxResources limit. I.e. to also check the constraint *after* picking a container that would be assigned. > In fair scheduler, Queue should not been assigned more containers when its > usedResource had reach the maxResource limit > ----------------------------------------------------------------------------------------------------------------------- > > Key: YARN-2083 > URL: https://issues.apache.org/jira/browse/YARN-2083 > Project: Hadoop YARN > Issue Type: Bug > Components: scheduler > Affects Versions: 2.3.0 > Reporter: Yi Tian > Labels: assignContainer, fair, scheduler > Fix For: 2.3.0 > > Attachments: YARN-2083.patch > > > In fair scheduler, FSParentQueue and FSLeafQueue do an > assignContainerPreCheck to guaranty this queue is not over its limit. > But the fitsIn function in Resource.java did not return false when the > usedResource equals the maxResource. > I think we should create a new Function "fitsInWithoutEqual" instead of > "fitsIn" in this case. -- This message was sent by Atlassian JIRA (v6.2#6252)