[ https://issues.apache.org/jira/browse/YARN-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008538#comment-14008538 ]
Wangda Tan commented on YARN-1368: ---------------------------------- [~jianhe], Thanks for addressing my comments, two more comments, 1. bq. it's a repeated field I think it's better to follow YARN's convention, repeated field uses plural formal of word, you can checkout yarn_server_common_service_protos.proto for examples, 2. It's better to add test for RegisterNodeManagerPBImpl as well, > Common work to re-populate containers’ state into scheduler > ----------------------------------------------------------- > > Key: YARN-1368 > URL: https://issues.apache.org/jira/browse/YARN-1368 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Bikas Saha > Assignee: Jian He > Attachments: YARN-1368.1.patch, YARN-1368.2.patch, YARN-1368.3.patch, > YARN-1368.4.patch, YARN-1368.5.patch, YARN-1368.combined.001.patch, > YARN-1368.preliminary.patch > > > YARN-1367 adds support for the NM to tell the RM about all currently running > containers upon registration. The RM needs to send this information to the > schedulers along with the NODE_ADDED_EVENT so that the schedulers can recover > the current allocation state of the cluster. -- This message was sent by Atlassian JIRA (v6.2#6252)