[ 
https://issues.apache.org/jira/browse/YARN-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Binglin Chang updated YARN-2103:
--------------------------------

    Description: 
Bug 1:
{code}
  SerializedExceptionProto proto = SerializedExceptionProto
      .getDefaultInstance();
  SerializedExceptionProto.Builder builder = null;
  boolean viaProto = false;
{code}

Since viaProto is false, we should initiate build rather than proto

Bug 2:
the class does not provide hashcode() and equals() like other PBImpl records, 
this class is used in other records, it may affect other records' behavior. 



  was:
{code}
  SerializedExceptionProto proto = SerializedExceptionProto
      .getDefaultInstance();
  SerializedExceptionProto.Builder builder = null;
  boolean viaProto = false;
{code}

Since viaProto is false, we should initiate build rather than proto



> Inconsistency between viaProto flag and initial value of 
> SerializedExceptionProto.Builder
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-2103
>                 URL: https://issues.apache.org/jira/browse/YARN-2103
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: YARN-2103.v1.patch
>
>
> Bug 1:
> {code}
>   SerializedExceptionProto proto = SerializedExceptionProto
>       .getDefaultInstance();
>   SerializedExceptionProto.Builder builder = null;
>   boolean viaProto = false;
> {code}
> Since viaProto is false, we should initiate build rather than proto
> Bug 2:
> the class does not provide hashcode() and equals() like other PBImpl records, 
> this class is used in other records, it may affect other records' behavior. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to