[ https://issues.apache.org/jira/browse/YARN-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14027118#comment-14027118 ]
Anubhav Dhoot commented on YARN-1365: ------------------------------------- >If an app did not register and do unregister directly, it’ll go through >successfully. should we return resync command here also and client is expected to do re-register and then unregister? As per discussion in YARN-1366 it seems like we wanted to allow unregister without register and this change was part of demonstrating that. The problems I can see are we are missing information like AM host, port thats provided only during register. Not sure if we need this once the attempt is finishing. I can revert this back to resync if we think we should not be breaking this or for any other issue. resync does make this simpler and I would vote for that. > ApplicationMasterService to allow Register and Unregister of an app that was > running before restart > --------------------------------------------------------------------------------------------------- > > Key: YARN-1365 > URL: https://issues.apache.org/jira/browse/YARN-1365 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Bikas Saha > Assignee: Anubhav Dhoot > Attachments: YARN-1365.001.patch, YARN-1365.002.patch, > YARN-1365.003.patch, YARN-1365.004.patch, YARN-1365.initial.patch > > > For an application that was running before restart, the > ApplicationMasterService currently throws an exception when the app tries to > make the initial register or final unregister call. These should succeed and > the RMApp state machine should transition to completed like normal. > Unregistration should succeed for an app that the RM considers complete since > the RM may have died after saving completion in the store but before > notifying the AM that the AM is free to exit. -- This message was sent by Atlassian JIRA (v6.2#6252)