[ https://issues.apache.org/jira/browse/YARN-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032226#comment-14032226 ]
Zhijie Shen commented on YARN-2032: ----------------------------------- [~mayank_bansal], thanks for the patch! Here're some quick comment after the first glance. 1. Why does this patch target branch-2 instead of trunk? 2. The packages of the newly added classes need to be updated after YARN-2107. 3. TTL configure should be put in YarnConfiguration. Another concern is that the data retention policy is different between Hbase and Leveldb. In Leveldb, we determine whether an entity is old enough according to TTL, and then delete it as well as its events. However, in HBase impl, it seems that deletion depends on each column family's TTL individually. In this case, it is possible that the entity is deleted, but its events (or part of them) are still there. 4. fromId and fromTs not implemented seems not be implemented yet. 5. Why do ENTITY_TABLE and INDEX_TABLE have the same schema? If I remember it correctly, we only index against the primary filters only. 6. Query parameters need to fully function, such as the secondary filters. > Implement a scalable, available TimelineStore using HBase > --------------------------------------------------------- > > Key: YARN-2032 > URL: https://issues.apache.org/jira/browse/YARN-2032 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Vinod Kumar Vavilapalli > Assignee: Mayank Bansal > Attachments: YARN-2032-branch-2-1.patch > > > As discussed on YARN-1530, we should pursue implementing a scalable, > available Timeline store using HBase. > One goal is to reuse most of the code from the levelDB Based store - > YARN-1635. -- This message was sent by Atlassian JIRA (v6.2#6252)