[ https://issues.apache.org/jira/browse/YARN-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033327#comment-14033327 ]
Wangda Tan commented on YARN-2074: ---------------------------------- Hi Jian, I've reviewed your patch, one question, Is following a bug? {code} int exitStatus = ContainerExitStatus.PREEMPTED; switch (event.getType()) { case LAUNCH_FAILED: RMAppAttemptLaunchFailedEvent launchFaileEvent = (RMAppAttemptLaunchFailedEvent) event; diags = launchFaileEvent.getMessage(); break; {code} amContainerExitStatus will be set to ContainerExitStatus.PREEMPTED in any case. If it's a bug, I think we should cover a AM completed/fail case and it shouldn't be treated as preempted. Thanks, > Preemption of AM containers shouldn't count towards AM failures > --------------------------------------------------------------- > > Key: YARN-2074 > URL: https://issues.apache.org/jira/browse/YARN-2074 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Vinod Kumar Vavilapalli > Assignee: Jian He > Attachments: YARN-2074.1.patch, YARN-2074.2.patch, YARN-2074.3.patch, > YARN-2074.4.patch, YARN-2074.5.patch > > > One orthogonal concern with issues like YARN-2055 and YARN-2022 is that AM > containers getting preempted shouldn't count towards AM failures and thus > shouldn't eventually fail applications. > We should explicitly handle AM container preemption/kill as a separate issue > and not count it towards the limit on AM failures. -- This message was sent by Atlassian JIRA (v6.2#6252)