[ 
https://issues.apache.org/jira/browse/YARN-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052719#comment-14052719
 ] 

Vinod Kumar Vavilapalli commented on YARN-2181:
-----------------------------------------------

Tx for the UI, it looks great!

Glanced at the patch, one comment - did not  do a detailed review - we don't 
usually name transitions based on what happens in it. For e.g. 
UpdatePreemptionMetricsTransition should instead be called something like 
ContainerFinishedTransition and other ContainerFinished***Transitions can 
inherit or invoke it.

It's likely this patch will conflict with YARN-415, please have a look at it 
and figure out the order of the patches. Thanks..

> Add preemption info to RM Web UI and add logs when preemption occurs
> --------------------------------------------------------------------
>
>                 Key: YARN-2181
>                 URL: https://issues.apache.org/jira/browse/YARN-2181
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager, webapp
>    Affects Versions: 2.4.0
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2181.patch, YARN-2181.patch, YARN-2181.patch, 
> YARN-2181.patch, YARN-2181.patch, YARN-2181.patch, YARN-2181.patch, 
> YARN-2181.patch, YARN-2181.patch, YARN-2181.patch, YARN-2181.patch, 
> YARN-2181.patch, YARN-2181.patch, YARN-2181.patch, YARN-2181.patch, 
> application page-1.png, application page.png
>
>
> We need add preemption info to RM web page to make administrator/user get 
> more understanding about preemption happened on app, etc. 
> And RM logs should have following properties:
> * Logs are retrievable when an application is still running and often flushed.
> * Can distinguish between AM container preemption and task container 
> preemption with container ID shown.
> * Should be INFO level log.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to