[ 
https://issues.apache.org/jira/browse/YARN-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Vasudev updated YARN-2233:
--------------------------------

    Attachment: apache-yarn-2233.3.patch

bq.    Shouldn't RMWebservices.DELEGATION_TOKEN_HEADER be a public constant? I 
don't know what the right place is, though, may be the tokenID-itself..

I'm not sure what the right place is either.

bq.    createDelegationToken: Null renewer check should be in ClientRMService?

Fixed.

bq.    It seems to me that all API implementations should take the fulll 
principle name if available.

Fixed.

bq.    Call this API as alpha too?

Fixed.

bq.    We should set all the fields of a DT - token, renewer, expiration-time 
all the time - new-token, renew-token? renewDelegationToken only returns only 
the expiry-time and getToken only returns the token. This is consistent with 
RPCs. But I think in a followup, we should fix this.

Fixed.

bq. Is renewal better posted as POST /ws/v1/cluster/renew-delegation-token?

I've changed the API to make renewal POST 
/ws/v1/cluster/delegation-token/expiration.
{quote}
    assertTrue(tok.getNextExpirationTime() > oldExpirationTime);
    You may want to put artificial sleeps, we have seen cases in the past where 
they turn up being the same failing the test
{quote}

Fixed.

{quote}
    testCancelDelegationToken
        // Ideally, the owner should be able to cancel his own tokens but a bug
        // prevent that
        This is fixed now..
        We should also look into the RM and validate that it is indeed 
cancelled?
{quote}

Fixed.


> Implement web services to create, renew and cancel delegation tokens
> --------------------------------------------------------------------
>
>                 Key: YARN-2233
>                 URL: https://issues.apache.org/jira/browse/YARN-2233
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>            Priority: Blocker
>         Attachments: apache-yarn-2233.0.patch, apache-yarn-2233.1.patch, 
> apache-yarn-2233.2.patch, apache-yarn-2233.3.patch
>
>
> Implement functionality to create, renew and cancel delegation tokens.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to