[
https://issues.apache.org/jira/browse/YARN-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063381#comment-14063381
]
Junping Du commented on YARN-1341:
----------------------------------
Thanks [~jlowe] for reply above and document work on umbrella JIRA. I think we
can add error handling session later for all cases according to discussion
above. Isn't it? I also agree retry (configurable or not) may not be necessary
at this point. We may add it if future if we really need it. [~devaraj.k], what
do you think?
The latest patch looks good to me overall. Some comments on tiny issues:
In NMTokenSecretManagerInNM.java
{code}
+ // if there was no master key, try the previous key
+ if (super.currentMasterKey == null) {
+ super.currentMasterKey = previousMasterKey;
+ }
{code}
Is above code still necessary given currentMasterKey will updated soon from RM
registration as what we discussed above?
> Recover NMTokens upon nodemanager restart
> -----------------------------------------
>
> Key: YARN-1341
> URL: https://issues.apache.org/jira/browse/YARN-1341
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 2.3.0
> Reporter: Jason Lowe
> Assignee: Jason Lowe
> Attachments: YARN-1341.patch, YARN-1341v2.patch, YARN-1341v3.patch,
> YARN-1341v4-and-YARN-1987.patch, YARN-1341v5.patch, YARN-1341v6.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
