[ 
https://issues.apache.org/jira/browse/YARN-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084869#comment-14084869
 ] 

Zhijie Shen commented on YARN-2033:
-----------------------------------

[~djp], thanks for you volunteering to review this big patch.

bq. I just take a glance at latest patch which looks pretty big for me and mix 
of code refactor (move location of TimelineClient, etc.),

In case of the big refactor work, I've already had two jiras for them: 
YARN-2298 and YARN-2302. Please note that in this jira I posted the patch of 
generic-history in timeline store only and the uber patch including all code 
changes (with _ALL suffix).

bq. side logic like: adding originalURL to ApplicationAttemptReport, etc. Can 
we break this patch to several pieces and create a sub JIRA for each one?

I prefer not to do it right now, because moving the minor change out is not 
going to squeeze this patch significant. Instead, I've to maintain a longer 
dependency chain of the outstanding patches. Do you agree?

> Investigate merging generic-history into the Timeline Store
> -----------------------------------------------------------
>
>                 Key: YARN-2033
>                 URL: https://issues.apache.org/jira/browse/YARN-2033
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Zhijie Shen
>         Attachments: ProposalofStoringYARNMetricsintotheTimelineStore.pdf, 
> YARN-2033.1.patch, YARN-2033.2.patch, YARN-2033.3.patch, YARN-2033.4.patch, 
> YARN-2033.Prototype.patch, YARN-2033_ALL.1.patch, YARN-2033_ALL.2.patch, 
> YARN-2033_ALL.3.patch, YARN-2033_ALL.4.patch
>
>
> Having two different stores isn't amicable to generic insights on what's 
> happening with applications. This is to investigate porting generic-history 
> into the Timeline Store.
> One goal is to try and retain most of the client side interfaces as close to 
> what we have today.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to