[
https://issues.apache.org/jira/browse/YARN-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088346#comment-14088346
]
Jian He commented on YARN-2212:
-------------------------------
looks good overall. minor comments:
- AllocateResponse#newInstance: the first newInstance should not be changed,
it’s marked stable
- // Should have exception: check exception type
> ApplicationMaster needs to find a way to update the AMRMToken periodically
> --------------------------------------------------------------------------
>
> Key: YARN-2212
> URL: https://issues.apache.org/jira/browse/YARN-2212
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-2212.1.patch, YARN-2212.2.patch,
> YARN-2212.3.1.patch, YARN-2212.3.patch, YARN-2212.4.patch, YARN-2212.5.patch,
> YARN-2212.5.patch, YARN-2212.5.rebase.patch, YARN-2212.6.patch,
> YARN-2212.6.patch, YARN-2212.7.patch, YARN-2212.7.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
