[ 
https://issues.apache.org/jira/browse/YARN-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093459#comment-14093459
 ] 

Jian He commented on YARN-2373:
-------------------------------

Larry, Thanks for the update.  But.. seems to be a bug again? should be 
"getPassword(sslConf, WEB_APP_KEYSTORE_PASSWORD_KEY)" ?
{code}
sslConf.get(getPassword(sslConf, WEB_APP_KEYSTORE_PASSWORD_KEY))
{code}
The test is testing CredentialProvider and the newly added helper API. can you 
add a test for loadSslConfiguration method ? 

> WebAppUtils Should Use configuration.getPassword for Accessing SSL Passwords
> ----------------------------------------------------------------------------
>
>                 Key: YARN-2373
>                 URL: https://issues.apache.org/jira/browse/YARN-2373
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Larry McCay
>         Attachments: YARN-2373.patch, YARN-2373.patch, YARN-2373.patch, 
> YARN-2373.patch
>
>
> As part of HADOOP-10904, this jira represents a change to WebAppUtils to 
> uptake the use of the credential provider API through the new method on 
> Configuration called getPassword.
> This provides an alternative to storing the passwords in clear text within 
> the ssl-server.xml file while maintaining backward compatibility with that 
> behavior.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to