[ https://issues.apache.org/jira/browse/YARN-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096230#comment-14096230 ]
Subramaniam Venkatraman Krishnan commented on YARN-2378: -------------------------------------------------------- [~jianhe], thanks for your detailed comments. I am attaching a patch that addresses it. Summary of changes: * getCheckLeafQueue renamed to getAndCheckLeafQueue * Add test case to move app to a sibling queue within the same parent * Removed unnecessary unreserve as we need to only the metrics which is already being done in SchedulerApplicationAttempt as you right pointed out. * Removed unwanted synchronized block * Updated SchedulerApplication#setQueue (nice catch). Added checks in test case. Also updated AppSchedulingInfo as it also maintains the queue name. > Adding support for moving apps between queues in Capacity Scheduler > ------------------------------------------------------------------- > > Key: YARN-2378 > URL: https://issues.apache.org/jira/browse/YARN-2378 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacityscheduler > Reporter: Subramaniam Venkatraman Krishnan > Assignee: Subramaniam Venkatraman Krishnan > Labels: capacity-scheduler > Attachments: YARN-2378.patch, YARN-2378.patch, YARN-2378.patch, > YARN-2378.patch > > > As discussed with [~leftnoteasy] and [~jianhe], we are breaking up YARN-1707 > to smaller patches for manageability. This JIRA will address adding support > for moving apps between queues in Capacity Scheduler. -- This message was sent by Atlassian JIRA (v6.2#6252)