[ https://issues.apache.org/jira/browse/YARN-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101097#comment-14101097 ]
Ivan Mitic commented on YARN-2190: ---------------------------------- Thanks Chuan for the new patch. I have a few minor comments left: 1. {code} jcrci.CpuRate = max(10000, vcores * 10000 / sysinfo.dwNumberOfProcessors); {code} Did you want {{min}} here? 2. {{vcores * 10000 / sysinfo.dwNumberOfProcessors}} Can you please add braces to signify that multiplication should be done before division? I think this is correct but I personally think it is better to be explicit. > Provide a Windows container executor that can limit memory and CPU > ------------------------------------------------------------------ > > Key: YARN-2190 > URL: https://issues.apache.org/jira/browse/YARN-2190 > Project: Hadoop YARN > Issue Type: New Feature > Components: nodemanager > Reporter: Chuan Liu > Assignee: Chuan Liu > Attachments: YARN-2190-prototype.patch, YARN-2190.1.patch, > YARN-2190.2.patch, YARN-2190.3.patch, YARN-2190.4.patch > > > Yarn default container executor on Windows does not set the resource limit on > the containers currently. The memory limit is enforced by a separate > monitoring thread. The container implementation on Windows uses Job Object > right now. The latest Windows (8 or later) API allows CPU and memory limits > on the job objects. We want to create a Windows container executor that sets > the limits on job objects thus provides resource enforcement at OS level. > http://msdn.microsoft.com/en-us/library/windows/desktop/ms686216(v=vs.85).aspx -- This message was sent by Atlassian JIRA (v6.2#6252)