[ 
https://issues.apache.org/jira/browse/YARN-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116431#comment-14116431
 ] 

Tsuyoshi OZAWA commented on YARN-2483:
--------------------------------------

Thanks for reporting, Ted. It looks a timing problem:
1. After RMAppAttemptState.ALLOCATED, AttemptStoredTransition will be triggered 
automatically.
2. As a result, AM will be launched and AM state will be LAUNCHED before 
checking a final state in waitForState.
We should create waitForState(EnumSet<RMAppAttemptState>) and make it accept 
both ALLOCATED and SCHEDULED in this case.

> TestAMRestart#testShouldNotCountFailureToMaxAttemptRetry fails due to 
> incorrect AppAttempt state
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2483
>                 URL: https://issues.apache.org/jira/browse/YARN-2483
>             Project: Hadoop YARN
>          Issue Type: Test
>            Reporter: Ted Yu
>
> From https://builds.apache.org/job/Hadoop-Yarn-trunk/665/console :
> {code}
> testShouldNotCountFailureToMaxAttemptRetry(org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart)
>   Time elapsed: 49.686 sec  <<< FAILURE!
> java.lang.AssertionError: AppAttempt state is not correct (timedout) 
> expected:<ALLOCATED> but was:<SCHEDULED>
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.failNotEquals(Assert.java:743)
>       at org.junit.Assert.assertEquals(Assert.java:118)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.MockAM.waitForState(MockAM.java:84)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.MockRM.sendAMLaunched(MockRM.java:417)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.MockRM.launchAM(MockRM.java:582)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.MockRM.launchAndRegisterAM(MockRM.java:589)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.MockRM.waitForNewAMToLaunchAndRegister(MockRM.java:182)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart.testShouldNotCountFailureToMaxAttemptRetry(TestAMRestart.java:402)
> {code}
> TestApplicationMasterLauncher#testallocateBeforeAMRegistration fails with 
> similar cause.
> These tests failed in build #664 as well.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to