[ https://issues.apache.org/jira/browse/YARN-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131700#comment-14131700 ]
Chris Douglas commented on YARN-1710: ------------------------------------- bq. I am not memoizing findEarliestTime, as it would only save one invocation (the others are on diff sets, or updated version of the same set) I'm confused. There are three invocations: {code} if (findEarliestTime(allocations.keySet()) > earliestStart) { allocations.put(new ReservationInterval(earliestStart, findEarliestTime(allocations.keySet())), ZERO_RES); } ReservationAllocation capReservation = new InMemoryReservationAllocation(reservationId, contract, user, plan.getQueueName(), findEarliestTime(allocations.keySet()), findLatestTime(allocations.keySet()), allocations, plan.getResourceCalculator(), plan.getMinimumAllocation()); {code} Isn't earliest time is either the earliest in the set, or the interval this just added? > Admission Control: agents to allocate reservation > ------------------------------------------------- > > Key: YARN-1710 > URL: https://issues.apache.org/jira/browse/YARN-1710 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Carlo Curino > Assignee: Carlo Curino > Attachments: YARN-1710.1.patch, YARN-1710.2.patch, YARN-1710.patch > > > This JIRA tracks the algorithms used to allocate a user ReservationRequest > coming in from the new reservation API (YARN-1708), in the inventory > subsystem (YARN-1709) maintaining the current plan for the cluster. The focus > of this "agents" is to quickly find a solution for the set of contraints > provided by the user, and the physical constraints of the plan. -- This message was sent by Atlassian JIRA (v6.3.4#6332)