[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146925#comment-14146925
]
Jian He commented on YARN-668:
------------------------------
Thanks Junping ! some comments on the patch:
- The newly added version id may not be needed. For compatibility issue, we can
either explicitly check the version id mismatch and throw version mismatch
exception, or we can just check the specific required field and throw logic
exception.
- indentation of the annotation
{code}
@Private
public ApplicationAttemptId getApplicationAttemptId() {
{code}
- {{AMRMTokenSecretManager#newInstance()}} if this method is only used by test,
we can move it to test?
- previous comment from Vinod: “The proto definitions need to be in
server-common. ”
- To convert stream into byte array. {{byte[] buffer =
IOUtils.toByteArray(dis);}}
> TokenIdentifier serialization should consider Unknown fields
> ------------------------------------------------------------
>
> Key: YARN-668
> URL: https://issues.apache.org/jira/browse/YARN-668
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Junping Du
> Priority: Blocker
> Attachments: YARN-668-demo.patch, YARN-668-v2.patch,
> YARN-668-v3.patch, YARN-668-v4.patch, YARN-668.patch
>
>
> This would allow changing of the TokenIdentifier between versions. The
> current serialization is Writable. A simple way to achieve this would be to
> have a Proto object as the payload for TokenIdentifiers, instead of
> individual fields.
> TokenIdentifier continues to implement Writable to work with the RPC layer -
> but the payload itself is serialized using PB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
