[
https://issues.apache.org/jira/browse/YARN-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152270#comment-14152270
]
Vinod Kumar Vavilapalli commented on YARN-2494:
-----------------------------------------------
bq. I think it still has problem: Even if we have store abstraction, we still
need some logic to guarantee labels being added are valid (e.g. we need check
if a label existed in collection, and label existed in node when we trying to
remove some labels from a node).
Then that validation code needs to get pulled out in a common layer. My goal it
not put the entire NodelabelsManager in yarn-common - it just doesn't belong
there.
bq. How about addToNodeLabelsCollection(), removeFromNodeLabelsCollection(),
addLabelsToNode() and removeLabelsFromNode()
bq. addToClusterNodeLabels(), removeFromClusterNodeLabels(), addLabelsToNode()
and removeLabelsFromNode().
[~leftnoteasy], [~cwelch], I'm okay with either of the above. Or should we call
it {{ClusterNodeLabelsCollection}}? :)
> [YARN-796] Node label manager API and storage implementations
> -------------------------------------------------------------
>
> Key: YARN-2494
> URL: https://issues.apache.org/jira/browse/YARN-2494
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-2494.patch, YARN-2494.patch, YARN-2494.patch,
> YARN-2494.patch, YARN-2494.patch, YARN-2494.patch
>
>
> This JIRA includes APIs and storage implementations of node label manager,
> NodeLabelManager is an abstract class used to manage labels of nodes in the
> cluster, it has APIs to query/modify
> - Nodes according to given label
> - Labels according to given hostname
> - Add/remove labels
> - Set labels of nodes in the cluster
> - Persist/recover changes of labels/labels-on-nodes to/from storage
> And it has two implementations to store modifications
> - Memory based storage: It will not persist changes, so all labels will be
> lost when RM restart
> - FileSystem based storage: It will persist/recover to/from FileSystem (like
> HDFS), and all labels and labels-on-nodes will be recovered upon RM restart
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
