[ https://issues.apache.org/jira/browse/YARN-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162917#comment-14162917 ]
Junping Du commented on YARN-2331: ---------------------------------- Thanks [~jlowe] for the patch. One thing I want to confirm here is: after this patch, if we setting "yarn.nodemanager.recovery.enabled" to true but setting "yarn.nodemanager.recovery.supervised" to false, we can still keep container running if we kill NM daemon by "kill -9" but go through "yarn-daemon.sh stop nodemanager" will kill running containers. Isn't it? > Distinguish shutdown during supervision vs. shutdown for rolling upgrade > ------------------------------------------------------------------------ > > Key: YARN-2331 > URL: https://issues.apache.org/jira/browse/YARN-2331 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager > Affects Versions: 2.6.0 > Reporter: Jason Lowe > Assignee: Jason Lowe > Attachments: YARN-2331.patch, YARN-2331v2.patch > > > When the NM is shutting down with restart support enabled there are scenarios > we'd like to distinguish and behave accordingly: > # The NM is running under supervision. In that case containers should be > preserved so the automatic restart can recover them. > # The NM is not running under supervision and a rolling upgrade is not being > performed. In that case the shutdown should kill all containers since it is > unlikely the NM will be restarted in a timely manner to recover them. > # The NM is not running under supervision and a rolling upgrade is being > performed. In that case the shutdown should not kill all containers since a > restart is imminent due to the rolling upgrade and the containers will be > recovered. -- This message was sent by Atlassian JIRA (v6.3.4#6332)