[ 
https://issues.apache.org/jira/browse/YARN-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174726#comment-14174726
 ] 

Jian He commented on YARN-2588:
-------------------------------

I traced the code ApplicationACLsManager/QueueACLsManager were earlier used by 
RMWebService for injection. this binding seems not necessary anymore. But 
anyways, this doesn't matter too much? as these two are just two classes and 
they are not extending service.

another minor comment in the patch, add {{Assert.fail()}} after 
{{rm.adminService.transitionToActive(requestInfo);}}
{code}
try {
+      rm.adminService.transitionToActive(requestInfo);
+    } catch (Exception e) {
+      assertTrue("Error when transitioning to Active mode".contains(e
+          .getMessage()));
+    }
{code}

> Standby RM does not transitionToActive if previous transitionToActive is 
> failed with ZK exception.
> --------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2588
>                 URL: https://issues.apache.org/jira/browse/YARN-2588
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.0.0, 2.6.0, 2.5.1
>            Reporter: Rohith
>            Assignee: Rohith
>         Attachments: YARN-2588.1.patch, YARN-2588.patch
>
>
> Consider scenario where, StandBy RM is failed to transition to Active because 
> of ZK exception(connectionLoss or SessionExpired). Then any further 
> transition to Active for same RM does not move RM to Active state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to