[ https://issues.apache.org/jira/browse/YARN-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175216#comment-14175216 ]
Wangda Tan commented on YARN-2504: ---------------------------------- Regarding test failures: - TestFairScheduler is tracked by YARN-2666 - TesApplicationClientProtocolOnHA is tracked by YARN-2286 - TestResourceTrackerOnHA will be resolved by YARN-2699 bq. RMAdminCLI.localMgr should be a singleton. Addressed, since RMAdminCLI is a single threaded class, add a simple singleton implementation bq. ocalNodeLabelsManager.stop() is still called in multiple places Addressed bq. Add a couple more positive tests to validate success of operations? There are positive tests for all write operations already, added more tests for read operation. Added comments on tests indicate they're successful of operations > Support get/add/remove/change labels in RM admin CLI > ----------------------------------------------------- > > Key: YARN-2504 > URL: https://issues.apache.org/jira/browse/YARN-2504 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Wangda Tan > Assignee: Wangda Tan > Attachments: YARN-2504-20141015-1.patch, YARN-2504-20141016-1.patch, > YARN-2504-20141016-2.patch, YARN-2504-20141016-3.patch, YARN-2504.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)